Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 13, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces a new GuidesSection and SDKSection to the storage usage page, enhancing user guidance on using the thirdweb storage service. It also refactors the YourFilesSection to improve file management features and updates the overall structure of the page.

Detailed summary

  • Added GuidesSection with links to documentation and tutorials.
  • Created SDKSection for code snippets in various languages.
  • Refactored YourFilesSection to improve file display and pagination.
  • Removed unused components and imports to streamline the code.
  • Updated the layout of the storage usage page for better organization.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: 24a53e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:31pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 13, 2024 7:31pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 13, 2024 7:31pm
wallet-ui ⬜️ Skipped (Inspect) Nov 13, 2024 7:31pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 15:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 15:20 Inactive
@MananTank MananTank marked this pull request as ready for review November 13, 2024 15:20
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 15:20 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 13, 2024
Copy link
Member Author

MananTank commented Nov 13, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.52%. Comparing base (9ea155e) to head (24a53e3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5408   +/-   ##
=======================================
  Coverage   45.52%   45.52%           
=======================================
  Files        1070     1070           
  Lines       55665    55665           
  Branches     4030     4030           
=======================================
  Hits        25341    25341           
  Misses      29637    29637           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9ea155e
packages 40.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.8 KB (0%) 896 ms (0%) 254 ms (+147.57% 🔺) 1.2 s
thirdweb (cjs) 105.11 KB (0%) 2.2 s (0%) 353 ms (+94.87% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 70 ms (+743.8% 🔺) 185 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 83 ms (+3329.37% 🔺) 93 ms
thirdweb/react (minimal + tree-shaking) 18.78 KB (0%) 376 ms (0%) 255 ms (+1741.99% 🔺) 630 ms

@MananTank MananTank force-pushed the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch from 96bdc5a to 3706d1f Compare November 13, 2024 16:31
@MananTank MananTank force-pushed the 11-13-migrate_usage_storage_page_to_shadcn_tailwind branch from b781a3f to e219ab9 Compare November 13, 2024 16:31
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 16:31 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 16:31 Inactive
@gregfromstl gregfromstl changed the title Migrate usage/storage page to shadcn+tailwind [Dashboard] Refactor: Migrate usage/storage page to shadcn+tailwind Nov 13, 2024
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 13, 2024

Merge activity

…5408)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on enhancing the `storage` section of the dashboard by introducing new components for guides, SDK integration, and file management, along with refactoring existing code for improved structure and readability.

### Detailed summary
- Deleted `TWQueryTable.tsx` and `RelevantDataSection.tsx`.
- Added `GuideSection` and `SDKSection` components for documentation and SDK integration.
- Introduced a new `GuidesSection` function to display links and videos.
- Refactored `YourFilesSection` to use a table format and improved pagination.
- Replaced `ChakraProviderSetup` with a simpler layout in the main `Page` component.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui branch from 3706d1f to 9ea155e Compare November 13, 2024 19:21
@MananTank MananTank force-pushed the 11-13-migrate_usage_storage_page_to_shadcn_tailwind branch from e219ab9 to 24a53e3 Compare November 13, 2024 19:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 13, 2024 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 13, 2024 19:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 13, 2024 19:22 Inactive
Base automatically changed from 11-13-migrate_codesegment_to_shadcn_tailwind_improved_ui to main November 13, 2024 19:33
@graphite-app graphite-app bot merged commit 24a53e3 into main Nov 13, 2024
29 of 31 checks passed
@graphite-app graphite-app bot deleted the 11-13-migrate_usage_storage_page_to_shadcn_tailwind branch November 13, 2024 19:34
@vercel vercel bot temporarily deployed to Production – docs-v2 November 13, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui November 13, 2024 19:34 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground November 13, 2024 19:34 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants